fix: exclude VASP data generator from pytest - #387
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 84.43% 84.43%
=======================================
Files 104 104
Lines 6110 6110
=======================================
Hits 5159 5159
Misses 951 951 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rename the fixture generator outside pytest patterns and guard generation behind an explicit main entry point. Closes deepmodeling#361 Coding-Agent: Codex Codex-Version: codex-cli 0.149.1 Model: gpt-5.6-sol Reasoning-Effort: xhigh
d3e0f9f to
9e16f04
Compare
Summary
main()functioncellpar_to_celldirectly instead of relying onase.geometryas a module attributeTests
pytest --collect-only -q tests/fp/data.vasp.kp.gf(no tests collected, no import-time failure)ruff format --check tests/fp/data.vasp.kp.gf/make_kp_data.pyisort --check-only tests/fp/data.vasp.kp.gf/make_kp_data.pygit diff --checkCloses #361
Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh