Skip to content

fix: exclude VASP data generator from pytest - #387

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-361-pytest-data-generator
Open

fix: exclude VASP data generator from pytest#387
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-361-pytest-data-generator

Conversation

@njzjz-bot

Copy link
Copy Markdown

Summary

  • rename the VASP fixture generator so it no longer matches pytest collection patterns
  • move generation into a documented main() function
  • import cellpar_to_cell directly instead of relying on ase.geometry as a module attribute

Tests

  • pytest --collect-only -q tests/fp/data.vasp.kp.gf (no tests collected, no import-time failure)
  • ruff format --check tests/fp/data.vasp.kp.gf/make_kp_data.py
  • isort --check-only tests/fp/data.vasp.kp.gf/make_kp_data.py
  • git diff --check

Closes #361

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e833338c-d568-40b9-b114-dc0667bec9ce

📥 Commits

Reviewing files that changed from the base of the PR and between 6b01f29 and 9e16f04.

📒 Files selected for processing (2)
  • tests/fp/data.vasp.kp.gf/make_kp_data.py
  • tests/fp/data.vasp.kp.gf/make_kp_test.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.43%. Comparing base (6b01f29) to head (9e16f04).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files         104      104           
  Lines        6110     6110           
=======================================
  Hits         5159     5159           
  Misses        951      951           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Rename the fixture generator outside pytest patterns and guard generation behind an explicit main entry point.

Closes deepmodeling#361

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.1
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@njzjz-bot
njzjz-bot force-pushed the fix/issue-361-pytest-data-generator branch from d3e0f9f to 9e16f04 Compare August 26, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Exclude VASP k-point data generator from pytest collection

1 participant