fix: preserve LAMMPS configuration indices - #384
Conversation
Copy task-group configuration and only supply an empty conf_idx default when the caller omitted the field. Closes deepmodeling#358 Coding-Agent: Codex Codex-Version: codex-cli 0.149.0 Model: gpt-5.6-sol Reasoning-Effort: xhigh
|
Warning Review limit reached
Next review available in: 36 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
==========================================
- Coverage 85.61% 84.20% -1.42%
==========================================
Files 92 104 +12
Lines 4852 6108 +1256
==========================================
+ Hits 4154 5143 +989
- Misses 698 965 +267 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
conf_idxvalueTests
PYTHONPATH=tests python -m unittest -v tests.exploration.test_make_task_group_from_config.TestMakeLmpTaskGroupFromConfig.test_npt_preserves_explicit_conf_idx tests.exploration.test_make_task_group_from_config.TestMakeLmpTaskGroupFromConfig.test_nptruff format --check dpgen2/exploration/task/make_task_group_from_config.py tests/exploration/test_make_task_group_from_config.pyisort --check-only dpgen2/exploration/task/make_task_group_from_config.py tests/exploration/test_make_task_group_from_config.pygit diff --checkCloses #358
Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh