Skip to content

fix: preserve LAMMPS configuration indices - #384

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-358-preserve-conf-idx
Open

fix: preserve LAMMPS configuration indices#384
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-358-preserve-conf-idx

Conversation

@njzjz-bot

Copy link
Copy Markdown

Summary

  • copy caller configuration before normalization
  • preserve an explicit conf_idx value
  • add the empty workaround only when the key is absent
  • cover the exported helper with an explicit index regression test

Tests

  • PYTHONPATH=tests python -m unittest -v tests.exploration.test_make_task_group_from_config.TestMakeLmpTaskGroupFromConfig.test_npt_preserves_explicit_conf_idx tests.exploration.test_make_task_group_from_config.TestMakeLmpTaskGroupFromConfig.test_npt
  • ruff format --check dpgen2/exploration/task/make_task_group_from_config.py tests/exploration/test_make_task_group_from_config.py
  • isort --check-only dpgen2/exploration/task/make_task_group_from_config.py tests/exploration/test_make_task_group_from_config.py
  • git diff --check

Closes #358

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Copy task-group configuration and only supply an empty conf_idx default when the caller omitted the field.

Closes deepmodeling#358

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@njzjz-bot, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d2d73711-f45e-4eaf-abd1-c565504401df

📥 Commits

Reviewing files that changed from the base of the PR and between b05af11 and 4cf94ce.

📒 Files selected for processing (2)
  • dpgen2/exploration/task/make_task_group_from_config.py
  • tests/exploration/test_make_task_group_from_config.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.20%. Comparing base (fa4a4cf) to head (4cf94ce).
⚠️ Report is 109 commits behind head on master.

Files with missing lines Patch % Lines
...n2/exploration/task/make_task_group_from_config.py 50.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   85.61%   84.20%   -1.42%     
==========================================
  Files          92      104      +12     
  Lines        4852     6108    +1256     
==========================================
+ Hits         4154     5143     +989     
- Misses        698      965     +267     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Preserve caller-provided conf_idx in make_lmp_task_group_from_config

1 participant