Skip to content

fix: infer optional CALYPSO inputs - #383

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-357-calypso-defaults
Open

fix: infer optional CALYPSO inputs#383
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-357-calypso-defaults

Conversation

@njzjz-bot

Copy link
Copy Markdown

Summary

  • infer atomic numbers from name_of_atoms when omitted
  • generate the required distance matrix from the maintained covalent-radius table
  • preserve explicit lists and per-element radius overrides
  • cover the fully omitted optional-field case through task generation

Tests

  • PYTHONPATH=tests python -m unittest -v tests.exploration.test_make_task_group_from_config.TestMakeCalyTaskGroupFromConfig.test_infers_optional_atomic_numbers_and_distances tests.exploration.test_make_task_group_from_config.TestMakeCalyTaskGroupFromConfig.test_caly_task_group
  • ruff format --check dpgen2/exploration/task/caly_task_group.py tests/exploration/test_make_task_group_from_config.py
  • isort --check-only dpgen2/exploration/task/caly_task_group.py tests/exploration/test_make_task_group_from_config.py
  • git diff --check

Closes #357

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3f9d69d5-fc97-4f84-8ddd-3873b00bdbf3

📥 Commits

Reviewing files that changed from the base of the PR and between 6b01f29 and 3a037c0.

📒 Files selected for processing (2)
  • dpgen2/exploration/task/caly_task_group.py
  • tests/exploration/test_make_task_group_from_config.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Infer atomic numbers and a covalent-radius distance matrix when optional CALYPSO fields are omitted.

Closes deepmodeling#357

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.1
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@njzjz-bot
njzjz-bot force-pushed the fix/issue-357-calypso-defaults branch from 262334f to 3a037c0 Compare August 26, 2026 11:00
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 26, 2026
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.43%. Comparing base (6b01f29) to head (3a037c0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files         104      104           
  Lines        6110     6111    +1     
=======================================
+ Hits         5159     5160    +1     
  Misses        951      951           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Align CALYPSO optional schema with required input generation

1 participant