fix: select SIESTA pseudopotentials per task - #1958
Conversation
Coding-Agent: Codex Codex-Version: codex-cli 0.149.0 Model: gpt-5.6-sol Reasoning-Effort: xhigh
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1958 +/- ##
==========================================
+ Coverage 49.80% 49.81% +0.01%
==========================================
Files 83 83
Lines 14986 14991 +5
==========================================
+ Hits 7464 7468 +4
- Misses 7522 7523 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
type_mapto its SIESTA pseudopotential files;Tests
cd tests/generator && /tmp/dpgen-test-env/bin/python -m unittest test_make_fp.TestMakeFPSIESTA.test_make_fp_siesta test_make_fp.TestMakeFPSIESTA.test_make_fp_siesta_with_element_subset -vruff check dpgen/generator/run.py tests/generator/test_make_fp.pyruff format --check dpgen/generator/run.py tests/generator/test_make_fp.pyFixes #1859
Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh