Skip to content

fix: deduplicate model deviation timesteps - #1956

Open
njzjz-bot wants to merge 1 commit into
masterfrom
fix/issue-1756-deduplicate-model-devi
Open

fix: deduplicate model deviation timesteps#1956
njzjz-bot wants to merge 1 commit into
masterfrom
fix/issue-1756-deduplicate-model-devi

Conversation

@njzjz-bot

Copy link
Copy Markdown
Collaborator

Summary

  • discard intermediate model-deviation evaluations that repeat an existing timestep;
  • retain the final evaluation because it corresponds to the accepted trajectory configuration;
  • preserve existing PIMD model-deviation merging behavior and add regression coverage.

Tests

  • cd tests/generator && /tmp/dpgen-test-env/bin/python -m unittest test_make_md.TestMakeModelDevi.test_read_model_devi_file_keeps_last_row_per_timestep test_make_md.TestMakeModelDevi.test_read_model_devi_file_pimd -v
  • ruff check dpgen/generator/run.py tests/generator/test_make_md.py
  • ruff format --check dpgen/generator/run.py tests/generator/test_make_md.py

Fixes #1756

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 54 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b6734b95-3629-4602-b0b5-5574a91187f7

📥 Commits

Reviewing files that changed from the base of the PR and between d5ce577 and 431c7f0.

📒 Files selected for processing (2)
  • dpgen/generator/run.py
  • tests/generator/test_make_md.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.81%. Comparing base (d5ce577) to head (431c7f0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
+ Coverage   49.80%   49.81%   +0.01%     
==========================================
  Files          83       83              
  Lines       14986    14990       +4     
==========================================
+ Hits         7464     7468       +4     
  Misses       7522     7522              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Multiple output per timestep in model_devi.out when using fix atom/swap in LAMMPS

1 participant