fix: validate simplify skill templates - #1950
Conversation
Make every bundled simplify JSON asset normalize against the current parameter and machine schemas. Document duplicated machine/resource batch types and use a schema-valid no-op command for disabled FP stages. Add regression coverage for all bundled JSON assets. Fixes #1918 Coding-Agent: Codex Codex-Version: codex-cli 0.149.0 Model: gpt-5.6-sol Reasoning-Effort: xhigh
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1950 +/- ##
=======================================
Coverage 49.80% 49.80%
=======================================
Files 83 83
Lines 14986 14986
=======================================
Hits 7464 7464
Misses 7522 7522 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes #1918.
This makes every bundled
dpgen-simplifyJSON asset normalize against DP-GEN current simplify parameter and machine schemas. It also updates the skill guidance to keepmachine.batch_typeandresources.batch_typeconsistent and supplies a schema-valid no-op command for inactive FP stages.Validation:
python -m unittest tests.test_check_skill_assets tests.test_check_examples -vruff check tests/test_check_skill_assets.pyruff format --check tests/test_check_skill_assets.pyThe skill quick validator still reports the pre-existing unsupported
compatibilityfrontmatter key; that unrelated metadata issue is unchanged.Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh