Skip to content

fix: validate simplify skill templates - #1950

Open
njzjz-bot wants to merge 1 commit into
masterfrom
codex/fix-1918-simplify-skill-templates
Open

fix: validate simplify skill templates#1950
njzjz-bot wants to merge 1 commit into
masterfrom
codex/fix-1918-simplify-skill-templates

Conversation

@njzjz-bot

Copy link
Copy Markdown
Collaborator

Fixes #1918.

This makes every bundled dpgen-simplify JSON asset normalize against DP-GEN current simplify parameter and machine schemas. It also updates the skill guidance to keep machine.batch_type and resources.batch_type consistent and supplies a schema-valid no-op command for inactive FP stages.

Validation:

  • python -m unittest tests.test_check_skill_assets tests.test_check_examples -v
  • ruff check tests/test_check_skill_assets.py
  • ruff format --check tests/test_check_skill_assets.py
  • JSON syntax validation for every bundled asset

The skill quick validator still reports the pre-existing unsupported compatibility frontmatter key; that unrelated metadata issue is unchanged.

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Make every bundled simplify JSON asset normalize against the current parameter and machine schemas. Document duplicated machine/resource batch types and use a schema-valid no-op command for disabled FP stages. Add regression coverage for all bundled JSON assets.

Fixes #1918

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 17 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 63ee78ae-cf5d-4fc3-8ab2-d367dd65e358

📥 Commits

Reviewing files that changed from the base of the PR and between d5ce577 and aa686f9.

📒 Files selected for processing (9)
  • skills/dpgen-simplify/SKILL.md
  • skills/dpgen-simplify/assets/machine.template.json
  • skills/dpgen-simplify/assets/machine.template.local-shell.json
  • skills/dpgen-simplify/assets/machine.template.server-local-slurm.json
  • skills/dpgen-simplify/assets/machine.template.ssh-remote-slurm.json
  • skills/dpgen-simplify/assets/param.example.qm7.from-official-docs.json
  • skills/dpgen-simplify/assets/param.template.json
  • skills/dpgen-simplify/references/machine-fields.md
  • tests/test_check_skill_assets.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.80%. Comparing base (d5ce577) to head (aa686f9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1950   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files          83       83           
  Lines       14986    14986           
=======================================
  Hits         7464     7464           
  Misses       7522     7522           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Make bundled simplify skill templates schema-valid

1 participant