fix: parse ABACUS binary options safely - #1949
Conversation
Fixes #1892 Coding-Agent: Codex Codex-Version: codex-cli 0.149.0 Model: gpt-5.6-sol Reasoning-Effort: xhigh
|
Warning Review limit reachedNext included review available in 24 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1949 +/- ##
==========================================
- Coverage 49.80% 49.80% -0.01%
==========================================
Files 83 83
Lines 14986 14982 -4
==========================================
- Hits 7464 7462 -2
+ Misses 7522 7520 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
eval()with an explicit parser for ABACUS 0/1 and boolean-style values.gamma_onlyhandling.Tests
python -m unittest tests.generator.test_abacus_safe_values -vruff check dpgen/generator/lib/abacus_scf.py dpgen/data/gen.py tests/generator/test_abacus_safe_values.pyruff format --check dpgen/generator/lib/abacus_scf.py dpgen/data/gen.py tests/generator/test_abacus_safe_values.pyeval(calls remain in the affected ABACUS paths.Fixes #1892
Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh