Skip to content

fix: require both property refine suffixes - #1939

Open
njzjz-bot wants to merge 1 commit into
masterfrom
codex/fix-1903-refine-suffix-detection
Open

fix: require both property refine suffixes#1939
njzjz-bot wants to merge 1 commit into
masterfrom
codex/fix-1903-refine-suffix-detection

Conversation

@njzjz-bot

Copy link
Copy Markdown
Collaborator

Summary

  • Centralize property work-suffix selection.
  • Treat a property as refine only when both init_from_suffix and output_suffix are present.
  • Apply the same rule to make, run, and post phases.
  • Add regression tests for partial and complete refine configuration.

Tests

  • python -m unittest tests.auto_test.test_make_prop.TestMakeProperty.test_output_suffix_alone_is_not_refine tests.auto_test.test_make_prop.TestMakeProperty.test_both_suffixes_enable_refine -v
  • ruff check dpgen/auto_test/common_prop.py tests/auto_test/test_make_prop.py
  • ruff format --check dpgen/auto_test/common_prop.py tests/auto_test/test_make_prop.py

Fixes #1903

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Fixes #1903

Coding-Agent: Codex

Codex-Version: codex-cli 0.149.0

Model: gpt-5.6-sol

Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 38 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e047b809-abf2-4140-b786-9e7e87b58993

📥 Commits

Reviewing files that changed from the base of the PR and between d5ce577 and c3d115f.

📒 Files selected for processing (2)
  • dpgen/auto_test/common_prop.py
  • tests/auto_test/test_make_prop.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.83%. Comparing base (d5ce577) to head (c3d115f).

Files with missing lines Patch % Lines
dpgen/auto_test/common_prop.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1939      +/-   ##
==========================================
+ Coverage   49.80%   49.83%   +0.02%     
==========================================
  Files          83       83              
  Lines       14986    14977       -9     
==========================================
  Hits         7464     7464              
+ Misses       7522     7513       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Require both suffix keys when detecting property refine jobs

1 participant