Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dargs/dargs.py
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,9 @@ def check_value(
"""
if allow_ref:
value = deepcopy(value)
# ``traverse_value`` only checks descendants, so validate the root value
# explicitly before descending into any sub-fields or variants.
self._check_data(value, [])
self.traverse_value(
value,
key_hook=Argument._check_exist,
Expand Down
10 changes: 10 additions & 0 deletions tests/test_checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,16 @@ def test_sub_fields(self) -> None:
with self.assertRaises(ValueError):
Argument("base", dict, [Argument("sub1", int), Argument("sub1", int)])

def test_check_value_validates_root(self) -> None:
"""Root types and extra checks are enforced by check_value()."""
with self.assertRaises(ArgumentTypeError):
Argument("value", int).check_value("not an integer")

positive = Argument("value", int, extra_check=lambda value: value > 0)
positive.check_value(1)
with self.assertRaises(ArgumentValueError):
positive.check_value(0)

def test_sub_repeat_list(self) -> None:
ca = Argument(
"base", list, [Argument("sub1", int), Argument("sub2", str)], repeat=True
Expand Down
Loading