chore: sync main into protocol-squad#405
Open
kuruk-mm wants to merge 9 commits into
Open
Conversation
Replaced bursts collection with wrapper
Adds SubscribeToTopic, PublishData and ConsumeMessages RPCs so scenes can exchange topic-scoped JSON payloads through the comms layer. Each void-returning RPC uses its own response message (following the TeleportToResponse pattern) to avoid colliding with the package-level EmptyResponse defined in restricted_actions.proto.
feat: audio analysis (#328) * component definition * specify package in the component def * apply lint * omit experimental features * support multiple analysis modes * relax order * optional args Co-authored-by: Gon Pombo <gonzalo@decentraland.org>
feat: add IA_MODIFIER input action (value 14) for Shift key The Decentraland desktop client already supports IA_MODIFIER at value 14, mapped to the Shift key. This adds the missing enum value to the protocol definition so the SDK type definitions stay in sync with the runtime. Co-authored-by: Nicolas Earnshaw <nearnshaw@decentraland.org>
# Conflicts: # proto/decentraland/sdk/components/common/input_action.proto
Test this pull request
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainintoprotocol-squadto pick up 7 commits.proto/decentraland/sdk/components/common/input_action.proto— both branches addedIA_MODIFIER = 14; kept main's version with the descriptive comment.Commits from main
Test plan
IA_MODIFIERenum value is preserved with main's comment