Add support for ESP32-S3 - #243
Open
nakoeppen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw #241, just decided to take an alternate (and potentially more thorough?) approach after having some minor setbacks with the other solution. Feel free to accept either PR, just thought I'd put this out there as well, excited to get S3 support one way or another! I was able to test this on an ESP32-S3 Supermini (HW-747) with a successful ping against an Apple device within minutes (although please note that more Apple devices in a close proximity help incredibly). Regardless of the approach we use, it will be important to consider that some ESP32-S3's (like the HW-747) are limited to 4MB of flash, so keeping that down will be imperative for widespread functionality.
I did modify the build instructions for ESP32-S3's a bit, but haven't yet tested a proper prebuilt binary. Currently I have stuck with the following inside of the firmware/ESP32 folder (after generating my keys & with the serial port adjusted accordingly for your environment).
I will test the build instructions more thoroughly with a proper binary shortly!