install dev group explicitly in setup_env#748
Open
Benjamin-Knight wants to merge 1 commit into
Open
Conversation
The setup script relied on uv installing the `dev` dependency group by default. That behaviour varies by uv version, so on a fresh devcontainer build the `dev` group (which provides pre-commit) was not installed and `pre-commit install` failed with `command not found`. Restore the explicit `--group dev` that was dropped in b9a4b8b, and run pre-commit via `uv run` so it no longer depends on the venv being active. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Benjamin-Knight
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Install the dev dependency group explicitly during devcontainer setup instead of relying on uv's implicit default-group behaviour. resolve #747
Changes
Why
uv's default-group behaviour varies by version, so --all-extras alone didn't reliably install the dev group. Naming it explicitly makes the devcontainer deterministic across uv versions, ensuring pre-commit, pytest, and other dev tooling are always available.