Migrate CLI argument handling back to main.py#1901
Open
rolandwalker wants to merge 1 commit into
Open
Conversation
rolandwalker
force-pushed
the
RW/migrate-cli-args-back-to-main-py
branch
from
eaf4ef7 to
af990fb
Compare
This is a bit of churn. We spun absolutely everything out of main.py in a series of steps, but it isn't required that the file have zero responsibilities. Here mycli/cli_args.py is removed, and its responsibilities brought back to main.py. Some values are also moved to constants.py to avoid circular imports.
rolandwalker
force-pushed
the
RW/migrate-cli-args-back-to-main-py
branch
from
af990fb to
475c693
Compare
scottnemes
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a bit of churn. We spun absolutely everything out of
main.pyin a series of steps, but it isn't required that the file have zero responsibilities.Here
mycli/cli_args.pyis removed, and its responsibilities brought back tomain.py.Some values are also moved to
constants.pyto avoid circular imports.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).