feat: support GALACTIC_GOBGP_GRPC_SERVER and GALACTIC_GOBGP_GRPC_PORT env vars#133
Merged
Conversation
… env vars - Add GALACTIC_ENABLE_GOBGP_GRPC_SERVER env var to toggle the GoBGP gRPC API server on/off - Add GALACTIC_GOBGP_GRPC_PORT env var to configure the gRPC listen port (default 50051) - Wire grpcListenAddress through NewRuntimeFactory into the GoBGP server Config - Extract buildServerOptions from newBgpServer for testability - Add unit tests for parseGrpcPort, parseGrpcListenAddress, and buildServerOptions
scotwells
approved these changes
Jun 25, 2026
scotwells
left a comment
scotwells
left a comment
Contributor
There was a problem hiding this comment.
Where do we document all of the env variables that are supported? I normally like using CLI args so it's easier to see all config options via --help.
Contributor
Author
|
Yeah i agree, i need to revise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch adds two new env vars to Galatic intended assist with troubleshooting. By default, the GoBGP gRPC server is disabled when
galactic-routerstarts up. This enables the gRPC server. When enabled, operators and developers can use thegobgpcli to introspect the GoBGP state.Changes