Feature/add configurable retry - #85
Open
alexbourret wants to merge 12 commits into
Open
Conversation
Contributor
|
[sc-333727] |
duynghiatran
self-requested a review
August 11, 2026 13:26
Contributor
Base automatically changed from
fix/var-templating-w-multiform-templating
to
master
August 18, 2026 12:28
Contributor
|
What you are trying to do works as expected but I see multiple important issues : 1. The retries goes over the "Rate limit (requests/m)" parameter :
2: I think "502 bad gateway" should be added to the list of http codes, it tends to happen a lot when services are not reachable 3: I think we should manage the "Retry-After" header that is usually sent back in case of 429 response. It makes no sense to retry directly if the service told us to retry after X seconds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixing issue 84