Skip to content

Feature/add configurable retry - #85

Open
alexbourret wants to merge 12 commits into
masterfrom
feature/add-configurable-retry
Open

Feature/add configurable retry#85
alexbourret wants to merge 12 commits into
masterfrom
feature/add-configurable-retry

Conversation

@alexbourret

Copy link
Copy Markdown
Collaborator

Fixing issue 84

@MayeulRousselet

Copy link
Copy Markdown
Contributor

[sc-333727]

@duynghiatran
duynghiatran self-requested a review August 11, 2026 13:26
@duynghiatran

Copy link
Copy Markdown
Contributor

The retry mechanism is great, but it currently counts the total retry per dataset, not per row. Is this intentional? Here in my example, the first request took 5 secs, but all other requests took only 1s because the first one was retried 5 times, and all the others are not

image

Base automatically changed from fix/var-templating-w-multiform-templating to master August 18, 2026 12:28
@yannickbetou-dku

Copy link
Copy Markdown
Contributor

What you are trying to do works as expected but I see multiple important issues :

1. The retries goes over the "Rate limit (requests/m)" parameter :

  • If I configure a rate limit of 1 requests per minutes, and retries every 1 seconds, it will still send a request every 1 seconds, removing the purpose of rate limiting.

2: I think "502 bad gateway" should be added to the list of http codes, it tends to happen a lot when services are not reachable

3: I think we should manage the "Retry-After" header that is usually sent back in case of 429 response. It makes no sense to retry directly if the service told us to retry after X seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants