feat: forward remote dynamic filter updates to coordinator - #635
Open
jayshrivastava wants to merge 2 commits into
Open
feat: forward remote dynamic filter updates to coordinator#635jayshrivastava wants to merge 2 commits into
jayshrivastava wants to merge 2 commits into
Conversation
This was referenced Aug 13, 2026
jayshrivastava
force-pushed
the
js/3-plan-dynamic-filters
branch
from
August 13, 2026 19:27
60dc39a to
7bee97e
Compare
jayshrivastava
force-pushed
the
js/3-plan-dynamic-filters
branch
from
August 17, 2026 18:54
7bee97e to
53be7d0
Compare
jayshrivastava
force-pushed
the
js/3-plan-dynamic-filters
branch
2 times, most recently
from
August 17, 2026 19:38
4fd1433 to
c29bcf1
Compare
jayshrivastava
force-pushed
the
js/3-plan-dynamic-filters
branch
from
August 18, 2026 18:15
c29bcf1 to
a7bb152
Compare
jayshrivastava
force-pushed
the
js/3-plan-dynamic-filters
branch
from
August 18, 2026 18:52
a7bb152 to
8bc2dc9
Compare
jayshrivastava
force-pushed
the
js/3-plan-dynamic-filters
branch
2 times, most recently
from
August 21, 2026 16:48
e1a6b47 to
77c9528
Compare
jayshrivastava
force-pushed
the
js/3-plan-dynamic-filters
branch
from
August 21, 2026 20:58
77c9528 to
dd39b56
Compare
jayshrivastava
force-pushed
the
js/3-plan-dynamic-filters
branch
from
August 22, 2026 15:00
dd39b56 to
fceebde
Compare
jayshrivastava
force-pushed
the
js/3-plan-dynamic-filters
branch
2 times, most recently
from
August 23, 2026 15:27
5912188 to
a60f964
Compare
Task-local consumer
producer F ────────────────> consumer F
shared expression; no RPC
Cross-task consumer
producer F ── boundary anchor F ──> SetPlanRequest.report_ids=[F]
│
├── wait_update() -----+
├── wait_complete() ---+--> latest observed F --RPC--> coordinator
└── query cancellation +--> stop
Derive the report allowlist from producer IDs intersected with network-boundary anchor IDs. Workers observe only allowlisted producers, while DataFusion continues updating task-local consumers directly in memory. Watch-based updates may naturally coalesce, and completion remains observed separately because it does not advance the generation.
jayshrivastava
force-pushed
the
js/3-plan-dynamic-filters
branch
from
August 23, 2026 15:35
a60f964 to
8d666d6
Compare
jayshrivastava
marked this pull request as ready for review
August 23, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
This stack of PRs implements distributed dynamic filtering #528
Problem
The
QueryCoordinatorneeds to receive partial dynamic filter updates from workers.Solution
We introduce a new
WorkerToCoordinatorMsgwhichIn this PR makes each worker unconditionally send updates (via
wait_update()andwait_complete()) to the coordinator for anydynamic_filter_remote_producer_idsin theSetPlanRequest. The purpose ofdynamic_filter_remote_producer_idsis to exclude any dynamic filters who only have local consumers - these don't need to be forwarded to the coordinator.