ci: dispatch the SEA-via-kernel integration leg behind kernel labels#403
Draft
mani-mathur-arch wants to merge 1 commit into
Draft
ci: dispatch the SEA-via-kernel integration leg behind kernel labels#403mani-mathur-arch wants to merge 1 commit into
mani-mathur-arch wants to merge 1 commit into
Conversation
mani-mathur-arch
force-pushed
the
mani/sea-kernel-c2-dispatch
branch
from
5f940a0 to
90122c9
Compare
mani-mathur-arch
force-pushed
the
mani/sea-kernel-nightly-e2e
branch
from
2a43d24 to
ebedfc7
Compare
mani-mathur-arch
force-pushed
the
mani/sea-kernel-c2-dispatch
branch
from
90122c9 to
2a9715b
Compare
mani-mathur-arch
force-pushed
the
mani/sea-kernel-nightly-e2e
branch
from
ebedfc7 to
23de162
Compare
mani-mathur-arch
force-pushed
the
mani/sea-kernel-c2-dispatch
branch
from
2a9715b to
21a18d7
Compare
Extend the driver-test dispatch so the Go integration suite can run against the SEA-via-kernel backend, selected by label — the analogue of the existing Thrift labels, not a copy. Adds one kernel-namespaced label: - integration-test-kernel → sea backend, passthrough (real warehouse) The label resolves both proxy_mode and a new go_mode (thrift vs sea), and go_mode rides in the repository_dispatch client_payload. databricks-driver-test reads it to decide whether to build the kernel static lib and run the tagged (databricks_kernel) leg; the Thrift labels send go_mode=thrift and are unchanged. The new label is added to the on-new-commit label-drop list and the skip-stub guidance. The kernel label is passthrough (not replay): the sea leg has no committed recordings to replay yet, so there is no sea replay label until those are captured. The required merge-queue gate stays Thrift-only (go_mode pinned to thrift): the kernel leg is previewable on demand but not a required gate until the SEA backend ships in a released driver. Co-authored-by: Isaac Signed-off-by: Mani Kaustubh Mathur <mani.mathur@databricks.com>
mani-mathur-arch
force-pushed
the
mani/sea-kernel-nightly-e2e
branch
from
23de162 to
fb098a1
Compare
mani-mathur-arch
force-pushed
the
mani/sea-kernel-c2-dispatch
branch
from
21a18d7 to
c9ff45d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extend the
databricks-driver-testdispatch so the Go integration suite can run against the SEA-via-kernel backend, selected by label — the analogue of the existing Thrift labels, not a copy.integration-testintegration-test-fullintegration-test-kernelHow
proxy_modeand a newgo_mode(thrift vs sea).go_moderides in therepository_dispatchclient_payload. The receiver in driver-test reads it to decide whether to build the kernel static lib and run thedatabricks_kernel-tagged leg. Thrift labels sendgo_mode: thriftand are unchanged.go_modepinned tothrift): the kernel leg is previewable on demand but not a required gate until the SEA backend ships in a released driver.Two-repo change
Driver-side half. The receiver-side half (read
go_mode, kernel build prerequisites, threadDATABRICKS_GO_MODE, guard sea+replay) is a separate PR indatabricks-driver-test. The runner + harness already handleDATABRICKS_GO_MODE=seaend-to-end.Testing
integration-test→thrift/replay,integration-test-full→thrift/passthrough,integration-test-kernel→sea/passthrough.Stacked on #402.
This pull request and its description were written by Isaac.