[VPEX][9] Rename target flags to match spec (--cluster-id, --dry-run, …)#5960
Open
rugpanov wants to merge 1 commit into
Open
[VPEX][9] Rename target flags to match spec (--cluster-id, --dry-run, …)#5960rugpanov wants to merge 1 commit into
rugpanov wants to merge 1 commit into
Conversation
Per the [P0] CLI Changes spec, rename the setup-local flags: - --cluster → --cluster-id - --serverless → --serverless-version - --job → --job-id - --check → --dry-run - --constraint-source → --constraint-source-url (still hidden) Updates the flag definitions, GetString/GetBool reads, the mutually-exclusive group, and the user-facing flag names in ValidateTargetFlags, noTargetMessage, the E_ENV_UNSUPPORTED hint, and the job-ambiguity errors in compute.go. Internal --check doc comments are updated to --dry-run for accuracy. Acceptance scripts and goldens regenerated. Co-authored-by: Isaac
This was referenced Jul 17, 2026
rugpanov
changed the title
Collaborator
Integration test reportCommit: 78f2249
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 10 slowest tests (at least 2 minutes):
|
anton-107
approved these changes
Jul 17, 2026
anton-107
left a comment
anton-107
left a comment
Contributor
There was a problem hiding this comment.
Reviewed as part of the full stack (#5960–#5965). Clean, mechanical rename with matching goldens — the flag definitions, GetString/GetBool reads, the mutually-exclusive group, and every user-facing message/hint move together, and the command stays Hidden. Approving.
One low/nit to fold in (here or in a follow-up):
- [nit] Stale
--checkreferences in test files. This PR's description says the internal--checkdoc comments were updated to--dry-run, but the test files were never touched:libs/localenv/pipeline_test.go(lines 29, 35, 39, 43, 47, 51, 122, 130, 150, 154, 159, 186) andlibs/localenv/constraints_test.go(128, 141) still say--check. Several aret.Error/assert-failure messages (e.g.pipeline_test.go:35"EnsureAvailable must not be called under --check"), so on failure a developer sees a message referencing a flag that no longer exists.
Reviewed with AI assistance (build + unit tests + adversarial verification against the checked-out top of stack).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5959 (the command rename).
What
Renames the
environments setup-localflags to match the[P0] CLI Changesspec:--cluster--cluster-id--serverless--serverless-version--job--job-id--check--dry-run--constraint-source--constraint-source-url(still hidden)Changes
GetString/GetBoolreads, and the mutually-exclusive group incmd/environments/sync.go.ValidateTargetFlags,noTargetMessage, theE_ENV_UNSUPPORTEDhint (constraints.go), and the job-ambiguity errors (compute.go).--checkdoc comments updated to--dry-runfor accuracy.No behavior change beyond the flag spellings; the command stays
Hidden.Testing
go build ./..., lint (0 issues), deadcode clean,libs/localenv+cmd/environmentsunit tests,acceptance/localenv+acceptance/helpregenerated and green.This pull request and its description were written by Isaac.