Create a new immutable snapshot when bundle permissions change#5957
Open
andrewnester wants to merge 1 commit into
Open
Create a new immutable snapshot when bundle permissions change#5957andrewnester wants to merge 1 commit into
andrewnester wants to merge 1 commit into
Conversation
Collaborator
Integration test reportCommit: 72c853e
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 10 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Jul 17, 2026
| @@ -0,0 +1,15 @@ | |||
| Local = true | |||
| Cloud = false # Temporary disable cloud tests until the API is fully available | |||
Contributor
There was a problem hiding this comment.
Can you add a Badness here so that we remember to flip this on at least? I think that's the convention we use in other tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Create a new immutable snapshot when bundle permissions change
Why
If the top-level permissions in the bundle change, we can't change the permission of corresponding snapshot because it's immutable. Hence instead we should create a new snapshot when permissions changed.
It's done by storing permissions hash as a metadata file in a snapshot zip.
Tests
Added an acceptance tests