acc: run Lakebase invariant tests on AWS and Azure via CONFIG_CloudName#5955
Open
pietern wants to merge 2 commits into
Open
acc: run Lakebase invariant tests on AWS and Azure via CONFIG_CloudName#5955pietern wants to merge 2 commits into
pietern wants to merge 2 commits into
Conversation
Collaborator
Integration test reportCommit: fbd7435
10 interesting tests: 4 SKIP, 3 flaky, 3 RECOVERED
Top 9 slowest tests (at least 2 minutes):
|
Add a CONFIG_CloudName=<aws|azure|gcp> pseudo-var alongside CONFIG_Cloud so EnvMatrixExclude rules can drop a variant on a single cloud rather than all clouds. It rides the same match-then-strip path in ExpandEnvMatrix, so it never leaks into the test environment, subtest names, or replacements. Use it to gate the Lakebase invariant templates on GCP only: both Lakebase v2 (postgres_*) and Lakebase v1 (database instances/catalogs/synced tables) are unavailable on GCP but work on AWS and Azure, so they now run on both instead of being excluded from all cloud runs. Co-authored-by: Isaac
pietern
force-pushed
the
lakebase-invariant-per-cloud
branch
from
July 17, 2026 10:05
639658c to
04550f4
Compare
pietern
marked this pull request as ready for review
July 17, 2026 10:08
Contributor
Approval status: pending
|
Running the invariant postgres templates on cloud (see the CONFIG_CloudName
change) surfaced pre-existing template bugs that never fired because these
templates had never run against a real backend:
- postgres_endpoint declared an explicit read-write endpoint, colliding with the
one the branch auto-provisions ("read_write endpoint already exists"). Take
over the implicit production branch and primary endpoint with replace_existing.
- postgres_branch created a new branch; switch it to take over the implicitly
provisioned production branch with replace_existing for consistency.
- postgres_synced_table referenced a project/branch it never declared ("Project
not found") and a nonexistent source table. Declare the full base-resource
chain (project, production branch, catalog, pipeline storage) and create a real
source table via an init/cleanup script pair, mirroring the dedicated
postgres_synced_tables resource test.
replace_existing does not exist in v0.293.0, so the seed deploy in continue_293
drops the unknown field and then fails creating the already-provisioned branch.
Exclude the three replace_existing templates from continue_293; they stay covered
by no_drift and migrate. Verified green on AWS and Azure.
Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5952.
Adds a
CONFIG_CloudName=<aws|azure|gcp>pseudo-var alongsideCONFIG_CloudsoEnvMatrixExcluderules can drop a variant on a single cloud instead of all clouds. It rides the same match-then-strip path inExpandEnvMatrix, so it never leaks into the test environment, subtest names, or replacements.Use it to gate the Lakebase invariant templates on GCP only: both Lakebase v2 (
postgres_*) and Lakebase v1 (database_instance/database_catalog/synced_database_table) are unavailable on GCP but work on AWS and Azure. #5952 excluded them from all cloud runs; this narrows that to GCP so they run on AWS and Azure again.This pull request and its description were written by Isaac.