Skip to content

chore: bump rust-dashcore pin for multilingual BIP-39 mnemonic parsing - #4455

Merged
QuantumExplorer merged 1 commit into
v4.2-devfrom
chore/bump-rust-dashcore-b66db390
Aug 22, 2026
Merged

chore: bump rust-dashcore pin for multilingual BIP-39 mnemonic parsing#4455
QuantumExplorer merged 1 commit into
v4.2-devfrom
chore/bump-rust-dashcore-b66db390

Conversation

@llbartekll

@llbartekll llbartekll commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pins fix/mnemonic-any-language-173ffac (a062ccb9) — the cherry-pick of dashpay/rust-dashcore#980 onto 173ffac0, the exact rev v4.2-dev already pins.

@coderabbitai

coderabbitai Bot commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7adf149e-f64a-4102-bd1c-5f7fbb6a91e0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@llbartekll
llbartekll requested a review from shumkov August 22, 2026 17:19
@thepastaclaw

thepastaclaw commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

🕓 Ready for review — 1 ahead in queue (commit faf02a3)
Queue position: 2/4
ETA: start ~18:10 UTC · complete ~18:39 UTC (median 29m across 30 recent reviews; 2 slots)
Queued 27m ago · Last checked: 2026-08-22 18:10 UTC

@llbartekll @claude
chore: bump rust-dashcore to a062ccb9 (multilingual BIP-39 mnemonic p…
faf02a3 
…arsing)

Pin fix/mnemonic-any-language-173ffac: the cherry-pick of
dashpay/rust-dashcore#980 onto 173ffac0, the rev v4.2-dev already pins.
This lands the BIP-39 fix without crossing the breaking key-wallet
sweep changes (rust-dashcore #961/#962/#966/#969) that #4406 adapts
platform to; once #4406 bumps onto rust-dashcore dev proper, the pin
rejoins dev and this branch can be deleted.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@llbartekll
llbartekll force-pushed the chore/bump-rust-dashcore-b66db390 branch from 2af6698 to faf02a3 Compare August 22, 2026 17:41
@llbartekll llbartekll changed the title chore: bump rust-dashcore to b66db390 (multilingual BIP-39 mnemonic parsing) chore: bump rust-dashcore pin for multilingual BIP-39 mnemonic parsing Aug 22, 2026
@llbartekll
llbartekll changed the base branch from chore/bump-rust-dashcore-dev-961 to v4.2-dev August 22, 2026 17:41
@llbartekll
llbartekll dismissed QuantumExplorer’s stale review August 22, 2026 17:41

The base branch was changed.

@github-actions github-actions Bot added this to the v4.2.0 milestone Aug 22, 2026
This was referenced Aug 22, 2026
Open
Draft
@QuantumExplorer
QuantumExplorer merged commit e141368 into v4.2-dev Aug 22, 2026
9 checks passed
@QuantumExplorer
QuantumExplorer deleted the chore/bump-rust-dashcore-b66db390 branch August 22, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer left review comments
@shumkov shumkov Awaiting requested review from shumkov
@lklimek lklimek Awaiting requested review from lklimek
@ZocoLini ZocoLini Awaiting requested review from ZocoLini

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@llbartekll @thepastaclaw @QuantumExplorer