fix: remove leftover [RATE] debug fprintfs from CAPI#43
Closed
willwade wants to merge 1 commit into
Closed
Conversation
Two debug fprintf(stderr, ...) statements were left in the CPS/WPM rate-tracking code (added in v0.1.8, #42): - editOutput: fired on every character push (line 478) - getCps: fired on every CPS read (line 1842) Both spam stderr in production. Removed. Signed-off-by: will wade <willwade@gmail.com>
Author
|
Superseded by #45 which includes the same fprintf removal plus the new dasher_reset_cps() function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two debug
fprintf(stderr, ...)statements were left in the CPS/WPM rate-tracking code (added in #42 / v0.1.8):editOutput(line 478): fired on every character push — one fprintf per keystrokegetCps(line 1842): fired on every CPS readBoth spam stderr in production builds. Removed both lines; no logic change.
Found by @owenpkent in Dasher-GTK #35 comment.