Skip to content

[Game Pass Catalog Browser] Fix importing EA Games into library - #769

Open
Chase868 wants to merge 1 commit into
darklinkpower:masterfrom
Chase868:master
Open

[Game Pass Catalog Browser] Fix importing EA Games into library#769
Chase868 wants to merge 1 commit into
darklinkpower:masterfrom
Chase868:master

Conversation

@Chase868

@Chase868 Chase868 commented Aug 15, 2026

Copy link
Copy Markdown

Description

This pull request fixes EA Play game imports in the Game Pass Catalog Browser extension. EA Play games were successfully retrieved from Microsoft's catalog feed and displayed in the catalog browser, but they could not be added to the Playnite library. Resolves #527

Root Cause & Issues Fixed

1. Manual EA Play Imports Were Rejected

EA Play catalog entries are assigned the ProductType.EaGame product type when processed:

ProcessGamePassCatalog(gamePassEaCatalogDownload, ProductType.EaGame);

However, XboxLibraryHelper.AddGameToLibrary only accepted entries with ProductType.Game. As a result, the following actions silently failed for EA Play games:

  • Adding an individual EA Play game from the catalog browser
  • Using the "Add all Catalog to the Playnite library" command

Fix: Updated the product-type validation to allow both ProductType.Game and ProductType.EaGame. Collection products remain excluded from import.

2. Automatic EA Play Imports Were Skipped

The automatic import path, used when AddNewGames is enabled, only called AddGameToLibrary for regular Game Pass games:

gamePassGame.ProductType == ProductType.Game

EA Play entries therefore never reached the library importer during catalog updates.

Fix: Updated the automatic import condition to process both regular Game Pass and EA Play game entries.

Files Changed

File Change
GamePassCatalogBrowserService.cs Allow automatic imports for ProductType.EaGame entries
XboxLibraryHelper.cs Allow manual and bulk imports for ProductType.EaGame entries

I have verified that:

  • These changes work, by building the extension and testing.
  • That the changes comply with the rules indicated in the repository.
  • Pull request is targeting master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[game pass catalog browser] EA Games don't get added to the library

1 participant