[Game Pass Catalog Browser] Fix importing EA Games into library - #769
Open
Chase868 wants to merge 1 commit into
Open
[Game Pass Catalog Browser] Fix importing EA Games into library#769Chase868 wants to merge 1 commit into
Chase868 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes EA Play game imports in the Game Pass Catalog Browser extension. EA Play games were successfully retrieved from Microsoft's catalog feed and displayed in the catalog browser, but they could not be added to the Playnite library. Resolves #527
Root Cause & Issues Fixed
1. Manual EA Play Imports Were Rejected
EA Play catalog entries are assigned the
ProductType.EaGameproduct type when processed:However,
XboxLibraryHelper.AddGameToLibraryonly accepted entries withProductType.Game. As a result, the following actions silently failed for EA Play games:Fix: Updated the product-type validation to allow both
ProductType.GameandProductType.EaGame. Collection products remain excluded from import.2. Automatic EA Play Imports Were Skipped
The automatic import path, used when
AddNewGamesis enabled, only calledAddGameToLibraryfor regular Game Pass games:EA Play entries therefore never reached the library importer during catalog updates.
Fix: Updated the automatic import condition to process both regular Game Pass and EA Play game entries.
Files Changed
GamePassCatalogBrowserService.csProductType.EaGameentriesXboxLibraryHelper.csProductType.EaGameentriesI have verified that:
masterbranch.