Remove deprecated dapr_dashboard from argocd sample#254
Open
nelson-parente wants to merge 1 commit into
Open
Conversation
Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
dapr/dashboardrepository has been archived and thedapr-dashboardHelm chart is being deprecated. The ArgoCD GitOps sample was enabling it via thedapr_dashboard.enabled: trueHelm value, which will produce warnings/errors as the chart is removed.dapr_dashboard:Helm values stanza fromdapr-argocd/gitops/dapr/application.yamldapr_dashboard/daprio/dashboardreferences exist in the repositoryTest plan
python3 -c "import yaml; list(yaml.safe_load_all(open('dapr-argocd/gitops/dapr/application.yaml')))"— passes