Skip to content

fix: remove usage of reserved per-action router fields#1767

Merged
javier-aliaga merged 1 commit into
dapr:masterfrom
javier-aliaga:fix/remove-reserved-action-router-usage
Jun 11, 2026
Merged

fix: remove usage of reserved per-action router fields#1767
javier-aliaga merged 1 commit into
dapr:masterfrom
javier-aliaga:fix/remove-reserved-action-router-usage

Conversation

@javier-aliaga

Copy link
Copy Markdown
Contributor

dapr/durabletask-protobuf#51 reserved the unused router fields on ScheduleTaskAction (4) and CreateChildWorkflowAction (5), which broke compilation since protos are downloaded from main at build time.

The runtime only reads the enclosing WorkflowAction.router, which was always set alongside the inner ones, so dropping the inner setters and their test assertions has no behavior change.

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

dapr/durabletask-protobuf#51 reserved the unused router fields on
ScheduleTaskAction (4) and CreateChildWorkflowAction (5), which broke
compilation since protos are downloaded from main at build time.

The runtime only reads the enclosing WorkflowAction.router, which was
always set alongside the inner ones, so dropping the inner setters and
their test assertions has no behavior change.

Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga requested review from a team as code owners June 11, 2026 13:50
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.86%. Comparing base (5a6ccef) to head (940d48a).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1767   +/-   ##
=========================================
  Coverage     76.86%   76.86%           
  Complexity     2298     2298           
=========================================
  Files           243      243           
  Lines          7141     7141           
  Branches        745      745           
=========================================
  Hits           5489     5489           
  Misses         1287     1287           
  Partials        365      365           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@javier-aliaga javier-aliaga merged commit 2d06cb4 into dapr:master Jun 11, 2026
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants