chore: remove the persona quiz onboarding step#6341
Merged
Conversation
Remove the FunnelPersonaQuiz step and all of its dead code and assets: - Delete the FunnelPersonaQuiz component, its CSS module, and the persona quiz engine/data/hook (steps/persona) - Drop the mascot (Patchy) video assets under public/onboarding - Remove the PersonaQuiz step type, step interface, stepper wiring, full-width entry, funnel target ids, and the CompletePersonaQuiz log event The separate PersonaSelector onboarding feature is left intact. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the persona quiz onboarding step (
FunnelPersonaQuiz) and all of its dead code and assets, since it's no longer needed.Changes
FunnelPersonaQuizcomponent, its CSS module, and the quiz engine/data/hook understeps/personapackages/webapp/public/onboarding(12.webm/.movfiles)PersonaQuizstep type, its step interface, theFunnelStepperwiring, thestepsFullWidthentry, thePersonaSelect/PersonaModifier/PersonaManualPickfunnel target ids, and theCompletePersonaQuizlog eventlib/image.tsthat referenced the removed componentKey decisions
PersonaSelectoronboarding feature (used byEditTag/TagSelection/SwipePersonaIntro, plusfeatureOnboardingPersonas, theOnboardingPersonasquery,Origin.OnboardingPersona, andLogEvent.SelectOnboardingPersona) is intentionally left intact — it is a different feature from the quiz.Verification
sharedtypecheck: no errors from changed filesFunnelStepper.spec.tsx: 18/18 passCloses ENG-1884
Created by Huginn 🐦⬛
Preview domain
https://eng-1884-clean-up-the-persona-qu.preview.app.daily.dev