Drop the polyfill for native workspace APIs - #14
Draft
grouville wants to merge 1 commit into
Draft
Conversation
The only polyfill surface this module used is moduleSource (dagger/dagger#13769): Workspace.moduleSource covers it, with contextDirectory / sourceRootSubpath in place of the polyfill's workspaceView / sourceRootPath. The engineVersion bump and the dependency removal land together, like the SDK migrations this module black-box-tests. Signed-off-by: Guillaume de Rouville <guillaume@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates this module off
github.com/dagger/polyfill— part of dagger/dagger#13769 (tracking checklist there; engine PRs dagger/dagger#13854 and dagger/dagger#13855).The only polyfill surface used here is
moduleSource:Workspace.moduleSourcecovers it, withcontextDirectory/sourceRootSubpathin place of the polyfill'sworkspaceView/sourceRootPath.Verified locally against a dev engine built from the two engine PRs:
dagger check— 22/22 passed.CI stays red until the engine release that ships these APIs exists. The
engineVersionbump assumesv1.0.0-beta.10— adjust if the release numbers differently. The bump and the dependency removal must land together: the version gate is what scopes the engine's new changeset rooting to migrated modules.