Drop the polyfill for native workspace APIs - #12
Draft
grouville wants to merge 1 commit into
Draft
Conversation
The engine now covers everything this SDK used the polyfill for (dagger/dagger#13769): findConfigDirs is Workspace.findConfigDirs, and module sources load through Workspace.moduleSource with moduleName / introspectionSchemaJSON read off the native ModuleSource. generateModule also stops hand-building its changeset from raw directory diffs: it stages through Workspace.fork, so the changeset comes back measured from the caller's cwd and a change outside the cwd is a loud error — hand-built root-measured diffs used to land in the wrong place when generating from a subdirectory. The engineVersion bump and the dependency removal land together: the version gate scopes the engine's new changeset rooting to migrated modules. Signed-off-by: Guillaume de Rouville <guillaume@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates this SDK off
github.com/dagger/polyfill, onto the engine's own workspace APIs — part of dagger/dagger#13769 (tracking checklist there; engine PRs dagger/dagger#13854 and dagger/dagger#13855).findConfigDirsbecomesws.findConfigDirs(inmain.dang.tmpl, the templatemain.dangis generated from — the rendered file follows viadagger generate templates:generate).Workspace.moduleSource, withmoduleName/introspectionSchemaJSONread off the nativeModuleSource.generateModuleandinitModulestop hand-building changesets from raw directory diffs: they stage throughWorkspace.fork, so the changeset comes back measured from the caller's cwd and a change outside the cwd is a loud error. The hand-built root-measured diffs used to land files in the wrong place when generating from a subdirectory.Verified locally against a dev engine built from the two engine PRs:
dagger check— every check that can run pre-release passes. Two groups cannot, both for the same reason CI itself stays red:"sdk": "java"fixture module: the engine resolves that SDK name togithub.com/dagger/dagger/sdk/java@<engineVersion>, and thev1.0.0-beta.10tag does not exist until the release is cutsdk-sdk:*contract checks, which install a release CLI inside their runner and therefore cannot load an SDK requiring the unreleased engineCI stays red until the engine release that ships these APIs exists. The
engineVersionbump assumesv1.0.0-beta.10— adjust if the release numbers differently. The bump and the dependency removal must land together: the version gate is what scopes the engine's new changeset rooting to migrated modules.