Include extension fields in Invoke-D365GenerateReportDataEntity (#649)#910
Open
pavankadabala-png wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Invoke-D365GenerateReportDataEntityreflects over data entities with the metadata disk provider and lists their fields, but it currently omits any fields added to an entity through extensions.This switches the entity read from
DataEntityViews.Read(...)toExtensionMethods.ReadDataEntityViewWithExtensions(...), so the generated report includes extension fields as well.Why
Closes #649. Full credit to @FH-Inway, who investigated the (undocumented) metadata API, identified the exact fix, and confirmed a working version in the issue thread.
Change
In
invoke-d365generatereportdataentity.ps1:ExtensionMethodslives in the sameMicrosoft.Dynamics.AX.Metadata.Storageassembly that is already loaded viaImport-GenerateReportAssemblies(and used forMetadataProviderFactory), so no new dependency is introduced. The disk provider is still used, so the cmdlet continues to run against uncompiled sources.Follow-up
As @FH-Inway noted,
Invoke-D365GenerateReportDataEntityField(via the internalGet-AXDataEntities) likely needs the same treatment. Happy to address that in a separate, focused PR.