Skip to content

refactor(cli): drop unnecessary Sync bound on prewarm resolve closure - #573

Merged
d-oit merged 1 commit into
mainfrom
chore/drop-sync-bound
Aug 11, 2026
Merged

refactor(cli): drop unnecessary Sync bound on prewarm resolve closure#573
d-oit merged 1 commit into
mainfrom
chore/drop-sync-bound

Conversation

@d-oit

@d-oit d-oit commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Relaxes the prewarm_domains closure bound from Fn(...) + Clone + Send + Sync + 'static to Fn(...) + Clone + Send + 'static.

Sync is never exercised: the closure is cloned per task and moved into each JoinSet task by value, so no code shares F by reference across threads. Dropping it accepts valid Send-but-not-Sync closures. No behavior change; cargo test 140 pass, clippy -D warnings clean.

@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
do-web-doc-resolover Ready Ready Preview Aug 11, 2026 8:18am

@deepsource-io

deepsource-io Bot commented Aug 11, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 83824da...97f442a on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Aug 11, 2026 8:18a.m. Review ↗
Python Aug 11, 2026 8:18a.m. Review ↗
Rust Aug 11, 2026 8:18a.m. Review ↗
Shell Aug 11, 2026 8:18a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@d-oit
d-oit merged commit 72bf164 into main Aug 11, 2026
51 checks passed
@d-oit
d-oit deleted the chore/drop-sync-bound branch August 11, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants