feat(cli): close out cache pre-warming with tests, config, and docs - #570
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript |  |
Aug 11, 2026 7:53a.m. | Review ↗ |
| Python | |
Aug 11, 2026 7:53a.m. | Review ↗ |
| Rust | |
Aug 11, 2026 7:53a.m. | Review ↗ |
| Shell | |
Aug 11, 2026 7:53a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Contributor
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 5 |
| Duplication | 4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
d-oit
pushed a commit
that referenced
this pull request
Aug 10, 2026
d-oit
pushed a commit
that referenced
this pull request
Aug 10, 2026
d-oit
pushed a commit
that referenced
this pull request
Aug 11, 2026
d-oit
force-pushed
the
feat/cache-prewarm-hardening
branch
from
August 11, 2026 07:43
ee20ceb to
765d2cc
Compare
d-oit
force-pushed
the
feat/cache-prewarm-hardening
branch
from
August 11, 2026 07:52
765d2cc to
8a9a3e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out Plan 11 (cache pre-warming): tests, config, and docs. The core (prewarm loop, web throttle) was already shipped; this lands the remaining offline-test, config, and documentation contracts.
Changes
cli/src/startup.rs— extract a testable coreprewarm_domains(resolver: impl Fn(String) -> Fut)behind the unchanged publicprewarm_cache(resolver, config)signature (per repo ADR-014 DI direction). Also fixes the join loop: after all tasks complete it now returns immediately instead of always sleeping the full 60sOVERALL_TIMEOUT(atokio::select!else/deadline interaction that blocked every CLI resolve for ~60s).cli/tests/startup_prewarm.rs— 2 offline tests: empty-domains skip guard (resolve fn never invoked), one resolve per domain.cli/tests/startup_semaphore.rs— 2 offline tests: peak in-flight ≤max_concurrency; no deadlock/timeout.cli/tests/config_prewarm.rs— 2 tests:[routing.prewarm]TOML →PrewarmConfiground-trip; defaults match the committed block.config.toml— add explicit[routing.prewarm]block (values matchdefaults.rs).agents-docs/CONFIG.md— document[routing.prewarm].Verification
cargo test: 138 passed / 15 suites (incl. new prewarm + config tests, now ~ms not 60s each)cargo clippy --all-targets -- -D warnings: cleancargo fmt --check: cleanscripts/validate_docs.py: 0 errors, 0 warnings; version sync + skill symlinks passgrep prewarm scripts/is empty — prewarm is Rust-CLI + Web only