-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ci): add reusable workflow template and expand workflow tests #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c2105b6
feat(ci): add reusable workflow template and expand workflow tests
d-oit 8ff1b0b
fix(ci): add trailing newlines to workflow template files
d-oit 776ea7a
refactor(test): extract permission helper and add file-existence guard
d-oit adab849
docs(plans): record pre-existing gitleaks license failure (Plan 115)
d-oit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Plan 115 — Gitleaks License Failure (Pre-existing Infrastructure Issue) | ||
|
|
||
| Date: 2026-08-11 | ||
|
|
||
| ## Issue | ||
|
|
||
| `Security Scan` workflow's **Secret Detection with GitLeaks** step fails on every PR: | ||
|
|
||
| ``` | ||
| 🛑 missing gitleaks license. Go grab one at gitleaks.io and store it as a | ||
| GitHub Secret named GITLEAKS_LICENSE. | ||
| ``` | ||
|
|
||
| Root cause chain (from CI logs, run 31520667156): | ||
|
|
||
| 1. `gitleaks/gitleaks-action@e0c47f4f8be36e29cdc102c57e68cb5cbf0e8d1e` (# v3.0.0) is pinned in `.github/workflows/security-scan.yml` (line 143). | ||
| 2. The action tries to look up the repo owner (`Get user [d-oit]`) to validate license-free usage. | ||
| 3. That API call fails with `self-signed certificate` — the runner cannot reach `api.github.com`. | ||
| 4. gitleaks then **enforces** license validation → no `GITLEAKS_LICENSE` secret is configured → hard failure. | ||
|
|
||
| ## Verification | ||
|
|
||
| - `security-scan.yml` on `main` is identical to the PR branch (not introduced by any PR). | ||
| - `gh secret list` shows **no** `GITLEAKS_LICENSE` secret → pre-existing. | ||
| - This check is **not** in the required status checks (only `Codacy Static Code Analysis` is required per branch rules). | ||
|
|
||
| ## Options | ||
|
|
||
| | Option | Effort | Notes | | ||
| |--------|--------|-------| | ||
| | Configure `GITLEAKS_LICENSE` repo secret | Low (needs gitleaks.io account + license) | Cleanest fix; unblocks the step | | ||
| | Pin gitleaks-action to v2.x | Low | v2 does not require a license; loses v3 features | | ||
| | Add `continue-on-error: true` to the gitleaks step | Trivial | TruffleHog fallback already exists at line 149-155; keeps scan non-blocking | | ||
|
|
||
| ## Recommendation | ||
|
|
||
| Option 1 (configure the secret) is the proper fix. As an interim, Option 3 (non-blocking with the existing TruffleHog fallback) prevents the red check without losing secret scanning coverage. Requires maintainer decision — no autonomous change made here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.