Hold every change to a review checklist and craft gate - #12
Merged
Conversation
Adopt the druks checklist at .druks/review/checklist.md, adapted for a public FastAPI service: platform-specific items dropped, the wire-boundary and typed-error rules kept, and a public-repo rule added — no internal ticket IDs or infra references anywhere. AGENTS.md points at it from Before Editing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the druks review checklist at
.druks/review/checklist.md, adapted for this repo, so the style regressions cleaned up in #10 don't come back.AGENTS.mdpoints at it from Before Editing.Adaptations from the druks original
.is_(None)query expressions are SQL, not control flow.🤖 Generated with Claude Code