[codex] Fix Firo Spark Name registration format#1413
Draft
reubenyap wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
P2PKH + OP_SPARKNAMEID <name> OP_DROP <sparkAddress> OP_DROPwhen building Spark Name registration transactions.bitcoindartscript compilation for canonical pushdata encoding.flutter_libsparkmobiledependency tofiroorg/flutter_libsparkmobile@171bc186663e3c7a573a6240f28f430e8d6b7d50.Why
Firo changed Spark Name registration transaction validation. Registration now needs the v2 Spark Name payload from the native library and a tagged transparent fee output so the fee output is bound to the registered name and Spark address.
Related
Review notes
This stays registration-only. Stack Wallet does not create Spark Name transfers, so transfer ownership fields/proofs are intentionally not added here.
Validation
git diff --checkpasses locally, with only Windows CRLF warnings.firoorg/flutter_libsparkmobilenative Windows CMake build was exercised from a temp clone and producedcodex-build/windows/shared/libflutter_libsparkmobile.dllusing local-only-DCMAKE_CXX_FLAGS=-fpermissive; the flag works around an existing vendored secp256k1/GCC 16 diagnostic, not this change.