fix(cubesql): preserve literal ORDER BY aliases - #11496
Open
jwils wants to merge 1 commit into
Open
Conversation
Sort pushdown can replace a grouped literal alias with the literal itself. Integer literals are then interpreted as positional ordinals by downstream databases such as Databricks. Reuse the generated group alias to keep wrapped SQL unambiguous.
jwils
marked this pull request as ready for review
August 6, 2026 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
CubeSQL sort pushdown can replace an aliased grouped integer literal with the literal itself. Databases that interpret integers in ORDER BY as positional ordinals can then reject the generated SQL when the ordinal exceeds the select-list width.
Risk Assessment
Low. The rewrite is limited to ORDER BY expressions that exactly match literal expressions in the same grouped select; all other sort expressions retain their existing behavior.
Validation