Skip to content

fix(core): declare the dist-only test target in six remaining jest configs #11486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igorlukanin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(core): declare the dist-only test target in six remaining jest configs #11486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/cubejs-backend-maven/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,9 @@ const base = require('../../jest.base.config');
module.exports = {
...base,
rootDir: '.',
// Suites run from the compiled output — the sources under test/ have no
// transform and cannot execute.
testMatch: [
'<rootDir>/dist/test/**/*.{test,spec}.{ts,js}'
],
};
5 changes: 5 additions & 0 deletions packages/cubejs-bigquery-driver/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,9 @@ const base = require('../../jest.base.config');
module.exports = {
...base,
rootDir: '.',
// Suites run from the compiled output — the sources under test/ have no
// transform and cannot execute.
testMatch: [
'<rootDir>/dist/test/**/*.{test,spec}.{ts,js}'
],
};
5 changes: 5 additions & 0 deletions packages/cubejs-databricks-jdbc-driver/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,9 @@ const base = require('../../jest.base.config');
module.exports = {
...base,
rootDir: '.',
// Suites run from the compiled output — the sources under test/ have no
// transform and cannot execute.
testMatch: [
'<rootDir>/dist/test/**/*.{test,spec}.{ts,js}'
],
};
5 changes: 5 additions & 0 deletions packages/cubejs-druid-driver/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ const base = require('../../jest.base.config');
module.exports = {
...base,
rootDir: '.',
// Suites run from the compiled output — the sources under test/ have no
// transform and cannot execute.
testMatch: [
'<rootDir>/dist/test/**/*.{test,spec}.{ts,js}'
],
Comment on lines +7 to +11

@claude claude Bot Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit (non-blocking): ts in the extension alternation is dead weight for a dist/ glob — the compiled output is .js only (and .d.ts can't match *.{test,spec}.{ts,js}, as the PR description notes). It does match the convention already used by cubejs-server/cubejs-testing/cubejs-testing-drivers, so keeping it for consistency is defensible; just flagging that the ts branch can never fire here.

Also worth noting the new configs use dist/test/**/* while the pre-existing dist-pointing configs use single-level dist/test/*. The **/ form is strictly more permissive and there are no subdirectories today, so no behaviour difference — but the sweep now leaves two shapes in the tree. Picking one (probably **/) and normalising the older four in a follow-up would make the convention greppable.

transformIgnorePatterns: [
'node_modules/(?!axios)/'
],
Expand Down
5 changes: 5 additions & 0 deletions packages/cubejs-duckdb-driver/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,9 @@ const base = require('../../jest.base.config');
module.exports = {
...base,
rootDir: '.',
// Suites run from the compiled output — the sources under test/ have no
// transform and cannot execute.
testMatch: [
'<rootDir>/dist/test/**/*.{test,spec}.{ts,js}'
],
};
5 changes: 5 additions & 0 deletions packages/cubejs-mysql-driver/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,9 @@ const base = require('../../jest.base.config');
module.exports = {
...base,
rootDir: '.',
// Suites run from the compiled output — the sources under test/ have no
// transform and cannot execute.
testMatch: [
'<rootDir>/dist/test/**/*.{test,spec}.{ts,js}'
],
};
Loading