Parallel sets: fix set name key conversion on set switch - #1361
Merged
Conversation
When switching sets via the ComboBox, the displayed name (with spaces) was being stored directly in settings.xml instead of the XML key (with underscores), causing a mismatch on next startup. Apply name_to_key() before storing parallel_set_current and before calling get_parallel_set() when switching sets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a single fix following #1356 (already merged).
Problem
When switching between parallel sets via the ComboBox in Preferences,
the displayed name (with spaces, e.g. "No OSHB") was being stored
directly in
settings.xmlasparallel_set_currentinstead of theXML key form (with underscores, e.g.
No_OSHB). This caused amismatch on next startup since the key lookup would fail.
Fix
Apply
name_to_key()before storingparallel_set_currentand beforecalling
get_parallel_set()when switching sets.Note
PR #1357 is superseded by this PR. The first commit
of #1357 (XML-invalid character fix) was already merged as #1356 by
you.