docs: correct feature flag tables across all versions#1123
Open
jbw976 wants to merge 1 commit into
Open
Conversation
The feature flag tables on the install pages had drifted from the flags the crossplane binary actually exposes. v2.1, v2.2, v2.3, and master were each missing several flags (--enable-operations, --enable-pipeline-inspector, etc.). This regenerates each table from the flags reported by `crossplane core start --help` on the matching build (v1.20.10, v2.1.7, v2.2.3, v2.3.3, and a v2.4.0-rc main build for master), verifying both flag name and Alpha/Beta status against the binary. Rows now follow a consistent order, with Beta flags before Alpha and alphabetical sorting within each group. v1.20's table was already complete and is reordered here to match the others. Its Helm values table also had pre-existing passive-voice and wordiness Vale warnings that the gate flags once the file is touched, so those are cleaned up too. Signed-off-by: Jared Watts <jbw976@gmail.com>
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature flag tables on the install pages were out of date and no longer matched the flags the core crossplane binary actually supports. All v2.x versions and
masterwere missing flags users can set, like--enable-operationsand--enable-pipeline-inspector. Anyone referencing these tables would miss real flags.Each table is now regenerated from the flags the binary reports, pulled straight from each version's release image:
Every flag's name and Alpha/Beta status was checked against the binary this way, across v1.20.10, v2.1.7, v2.2.3, v2.3.3, and a v2.4.0-rc
mainbuild formaster.Rows are now ordered consistently, with Beta before Alpha and alphabetical sorting within each group.
--enable-webhooksstays out, since it's a general flag rather than an Alpha/Beta feature flag.v1.20's table was already complete and is just reordered to match. Its Helm values table had pre-existing passive-voice and wordiness warnings that the Vale gate surfaces once the file is touched, so those are fixed here too.