Fix #653: defined() not recognizing ## token paste in its operand (GNU extension) - #694
Open
ludviggunne wants to merge 3 commits into
Open
Fix #653: defined() not recognizing ## token paste in its operand (GNU extension)#694ludviggunne wants to merge 3 commits into
ludviggunne wants to merge 3 commits into
Conversation
danmar
reviewed
Aug 5, 2026
danmar
reviewed
Aug 5, 2026
| macroName += defToken->next->next->next->str(); | ||
| lastToken = defToken->next->next->next; | ||
| while (argTok->name) { | ||
| if (expandArg(temp, argTok, parametertokens)) |
Collaborator
There was a problem hiding this comment.
I am not sure that we should expand macros unless they are operands. will this work:
#define x
#if defined(x)
the macroName will be empty string here now? and we will think that the condition is false?
Collaborator
Author
There was a problem hiding this comment.
It works, it takes a different execution path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.