-
Notifications
You must be signed in to change notification settings - Fork 23
chore: bump LLVM to 77e43ec1 (May 21, 2026) #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,29 +12,7 @@ | |
| #define MRDOCS_SHARE_HEADERS_LIBC_STUBS_NEW_H | ||
|
|
||
| #if defined(_LIBCPP_ABI_VCRUNTIME) | ||
| namespace std { | ||
| enum class align_val_t : size_t {}; | ||
| struct nothrow_t { explicit nothrow_t() = default; }; | ||
| extern const std::nothrow_t nothrow; | ||
| } | ||
|
|
||
| // Replaceable allocation functions | ||
| void* operator new ( std::size_t count ); | ||
| void* operator new[]( std::size_t count ); | ||
| void* operator new ( std::size_t count, std::align_val_t al ); | ||
| void* operator new[]( std::size_t count, std::align_val_t al ); | ||
|
|
||
| // Replaceable non-throwing allocation functions | ||
| void* operator new ( std::size_t count, const std::nothrow_t& tag ); | ||
| void* operator new[]( std::size_t count, const std::nothrow_t& tag ); | ||
| void* operator new ( std::size_t count, std::align_val_t al, | ||
| const std::nothrow_t& tag ) noexcept; | ||
| void* operator new[]( std::size_t count, std::align_val_t al, | ||
| const std::nothrow_t& tag ) noexcept; | ||
|
|
||
| // Non-allocating placement allocation functions | ||
| void* operator new ( std::size_t count, void* ptr ); | ||
| void* operator new[]( std::size_t count, void* ptr ); | ||
| #include <vcruntime_new.h> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting. Is this something being fixed in passing or do we have something about the new version that interacts with the libc stubs? In fact, I would have this question about all other changes to the libc stubs. It's unexpected to me that they interacted in an LLVM bump. |
||
| #endif | ||
|
|
||
| #endif // MRDOCS_SHARE_HEADERS_LIBC_STUBS_NEW_H | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // | ||
| // Licensed under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| // Copyright (c) 2024 Alan de Freitas (alandefreitas@gmail.com) | ||
| // | ||
| // Official repository: https://github.com/cppalliance/mrdocs | ||
| // | ||
|
|
||
| #ifndef MRDOCS_SHARE_HEADERS_LIBC_STUBS_VCRUNTIME_NEW_H | ||
| #define MRDOCS_SHARE_HEADERS_LIBC_STUBS_VCRUNTIME_NEW_H | ||
|
|
||
| namespace std { | ||
| enum class align_val_t : size_t {}; | ||
| struct nothrow_t { explicit nothrow_t() = default; }; | ||
| extern const std::nothrow_t nothrow; | ||
| } | ||
|
|
||
| // Replaceable allocation functions | ||
| void* operator new ( std::size_t count ); | ||
| void* operator new[]( std::size_t count ); | ||
| void* operator new ( std::size_t count, std::align_val_t al ); | ||
| void* operator new[]( std::size_t count, std::align_val_t al ); | ||
|
|
||
| // Replaceable non-throwing allocation functions | ||
| void* operator new ( std::size_t count, const std::nothrow_t& tag ); | ||
| void* operator new[]( std::size_t count, const std::nothrow_t& tag ); | ||
| void* operator new ( std::size_t count, std::align_val_t al, | ||
| const std::nothrow_t& tag ) noexcept; | ||
| void* operator new[]( std::size_t count, std::align_val_t al, | ||
| const std::nothrow_t& tag ) noexcept; | ||
|
|
||
| // Non-allocating placement allocation functions | ||
| void* operator new ( std::size_t count, void* ptr ); | ||
| void* operator new[]( std::size_t count, void* ptr ); | ||
|
|
||
| #endif // MRDOCS_SHARE_HEADERS_LIBC_STUBS_VCRUNTIME_NEW_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What’s this profraw issue? The explanation is more descriptive than explanatory of the motivation of the command. It seems to me like if this is happening and coverage is globing the wrong directory, that’s what should be fixed instead of a second workaround to accommodate the first mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that the coverage step scans build/ for *.profraw, which happens to include the *.profraw test fixtures in the LLVM extracted source tree; but they are in an older format, which makes the llvm-profdata merge fail. I'm not sure why this issue didn't occur when the cache was cold, the first time. Yes, this would better be fixed in the action.