Fix nullability mismatch in deprecated newConfig extension#122
Merged
Conversation
getCollectionConfigs() was tightened to take a non-null
BaseReplicatorConfiguration (CBL-7303), but the re-added 3.x
deprecated ReplicatorConfiguration?.newConfig extension still
passes its nullable receiver, breaking compilation.
Guard the call with this?.let { getCollectionConfigs(it) }. This
matches the 3.3 behavior: the ReplicatorConfiguration constructor
treats a null collection map as empty, so a null receiver yields
an empty configuration exactly as before.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This is a release branch and commits are restricted. Please confirm this PR is one of the following:
|
Member
Author
|
Regression within the branch |
pasin
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
./gradlew ciBuildfails to compile with:getCollectionConfigs()was tightened to take a non-nullBaseReplicatorConfiguration(CBL-7303), but the re-added 3.x deprecatedReplicatorConfiguration?.newConfigextension still passes its nullable receiverthis, breaking compilation.Fix
Guard the call with
this?.let { getCollectionConfigs(it) }.This matches the 3.3 behavior exactly: the
ReplicatorConfiguration(Endpoint, Map?)constructor treats a null collection map as empty (new HashMap<>()), so a null receiver yields an empty configuration just asgetCollectionConfigs(null)returned null in 3.3.🤖 Generated with Claude Code