Skip to content

Putri/add maintenance banner - #37

Open
putrikarunia wants to merge 9 commits into
masterfrom
putri/add-maintenance-banner
Open

Putri/add maintenance banner#37
putrikarunia wants to merge 9 commits into
masterfrom
putri/add-maintenance-banner

Conversation

@putrikarunia

Copy link
Copy Markdown
Collaborator
  • Show banner at top of site based on customization

Comment thread src/loader/index.ts
Comment on lines +278 to +293
var fontStyle1 = document.createElement("link");
fontStyle1.rel = "stylesheet";
fontStyle1.href =
"https://fonts.googleapis.com";
fontStyle1.rel = "preconnect"
var fontStyle2 = document.createElement("link");
fontStyle2.rel = "stylesheet";
fontStyle2.href =
"https://fonts.gstatic.com";
fontStyle2.rel = "preconnect"
fontStyle2.crossOrigin = "true"
var fontStyle3 = document.createElement("link");
fontStyle3.rel = "stylesheet";
fontStyle3.href =
"https://fonts.googleapis.com/css2?family=Inter:wght@400;500&display=swap";
fontStyle3.rel = "stylesheet"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like we only use Inter? are all of these links needed?

Comment thread package.json
{
"name": "cotter",
"version": "0.3.34",
"version": "0.3.36-beta.4",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should merge #36 this first then

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably make it 0.3.35 too ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants