Skip to content

refactor: use tailwind spacing scale utilities instead of arbitrary px values #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wendyyuchensun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: use tailwind spacing scale utilities instead of arbitrary px values #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/core/toast/toast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ const Toast = ({ toast, onRemove, onRemoveStart }) => {
key={id}
role="status"
aria-live="polite"
className={`min-h-8 w-80 pl-4 pr-2 py-[6px] flex items-center gap-1 text-sm mb-2 rounded-lg ${toastTypeClasses[type]}`}
className={`min-h-8 w-80 pl-4 pr-2 py-1.5 flex items-center gap-1 text-sm mb-2 rounded-lg ${toastTypeClasses[type]}`}
onMouseEnter={handlePause}
onMouseLeave={handleResume}
>
Expand Down
8 changes: 4 additions & 4 deletions src/components/core/tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,12 @@ const Tooltip = ({ children, label, position = 'top' }) => {
});

const arrowClass = {
top: 'absolute left-1/2 -translate-x-1/2 -bottom-[14px] border-[7px] border-transparent border-t-[#1A1A1A99]',
top: 'absolute left-1/2 -translate-x-1/2 -bottom-3.5 border-[7px] border-transparent border-t-[#1A1A1A99]',
bottom:
'absolute left-1/2 -translate-x-1/2 -top-[14px] border-[7px] border-transparent border-b-[#1A1A1A99]',
left: 'absolute top-1/2 -translate-y-1/2 -right-[14px] border-[7px] border-transparent border-l-[#1A1A1A99]',
'absolute left-1/2 -translate-x-1/2 -top-3.5 border-[7px] border-transparent border-b-[#1A1A1A99]',
left: 'absolute top-1/2 -translate-y-1/2 -right-3.5 border-[7px] border-transparent border-l-[#1A1A1A99]',
right:
'absolute top-1/2 -translate-y-1/2 -left-[14px] border-[7px] border-transparent border-r-[#1A1A1A99]',
'absolute top-1/2 -translate-y-1/2 -left-3.5 border-[7px] border-transparent border-r-[#1A1A1A99]',
};

return (
Expand Down
10 changes: 3 additions & 7 deletions src/components/header/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,22 +31,18 @@ const Header = ({ onImportClick, onExportClick, title, onTitleChange }) => {
<div className="flex items-center gap-3">
<Button
variant="tertiary"
className="min-w-[64px] lg:min-w-[88px] flex items-center gap-1"
className="min-w-16 lg:min-w-[88px] flex items-center gap-1"
onClick={() => setShowTipModal(true)}
>
<IconBulb size={16} aria-hidden="true" />
<span>{t('instructions')}</span>
</Button>
<Menu />
<LanguageMenu />
<Button
variant="secondary"
className="min-w-[64px] lg:min-w-[88px]"
onClick={onImportClick}
>
<Button variant="secondary" className="min-w-16 lg:min-w-[88px]" onClick={onImportClick}>
{t('import')}
</Button>
<Button variant="primary" className="min-w-[64px] lg:min-w-[88px]" onClick={onExportClick}>
<Button variant="primary" className="min-w-16 lg:min-w-[88px]" onClick={onExportClick}>
{t('export')}
</Button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/header/language-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const LanguageMenu = () => {
triggerButton={
<Button
variant="tertiary"
className="min-w-[64px] lg:min-w-[88px]"
className="min-w-16 lg:min-w-[88px]"
aria-label={t('changeLocale')}
>
<IconLanguage size={16} className="flex-none mr-1" aria-hidden="true" />
Expand Down
2 changes: 1 addition & 1 deletion src/components/header/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const NativeMenu = () => {
return (
<DropdownMenu
triggerButton={
<Button variant="tertiary" className="min-w-[64px] lg:min-w-[88px]" aria-label={t('more')}>
<Button variant="tertiary" className="min-w-16 lg:min-w-[88px]" aria-label={t('more')}>
<IconDots size={16} className="flex-none mr-1" aria-hidden="true" />
<span>{t('more')}</span>
</Button>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/home/home.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ export default function Home() {
items={latexDelimiterOptions}
value={displayConfig.latexDelimiter}
onChange={(option) => setDisplayConfig({ latexDelimiter: option })}
buttonClassName="w-[64px] h-7"
buttonClassName="w-16 h-7"
/>
</div>
<Button variant="secondary" onClick={insertMark}>
Expand Down