Skip to content

Bug with subprocess and arguments #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexbartol wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bug with subprocess and arguments #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e10af1
subprocess.Popen requires a list not string and will fail with a comp…
Oct 12, 2016
7cb1992
Reverted python-wrapper version to correct number
Oct 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/python/install_shield_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env jython

import subprocess
import shlex

import hudson.model.Computer as Computer
import hudson.Util as Util
Expand Down Expand Up @@ -79,7 +80,8 @@ def perform(build, launcher, listener):
command += ' ' + arguments
# launch InstallShield builder (ISCmdBld.exe)
logger.println("Executing command: " + command)
popen = subprocess.Popen(command, shell=False,
command_list = shlex.split(command)
popen = subprocess.Popen(command_list, shell=False,
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
(stdoutdata, stderrdata) = popen.communicate()
for line in stdoutdata.splitlines():
Expand Down