feat: migrate Release, Workflow, PublishQueue & PublishRule modules to System.Text.Json#187
Draft
OMpawar-21 wants to merge 1 commit into
Draft
feat: migrate Release, Workflow, PublishQueue & PublishRule modules to System.Text.Json#187OMpawar-21 wants to merge 1 commit into
OMpawar-21 wants to merge 1 commit into
Conversation
…o System.Text.Json - Replace Newtonsoft.Json attributes with System.Text.Json equivalents in ReleaseModel, PublishRuleModel, and DeleteReleaseItemService - Fix FetchDeleteService/CreateUpdateService call sites in Workflow, PublishRule, PublishQueue, Release, and ReleaseItem (remove legacy serializer argument) - Uncomment Stack.Release(), Stack.Workflow(), and Stack.PublishQueue() methods - Remove <Compile Remove> exclusions from core, unit test, and integration test projects - Update unit test assertions from OpenJObjectResponse (Newtonsoft) to OpenJsonObjectResponse (STJ) - Migrate Contentstack004_ReleaseTest integration test from Newtonsoft.Json.Linq to System.Text.Json.Nodes - Implement EnsureBulkTestWorkflowAndPublishingRuleAsync in BulkOperationTest to restore workflow/publish rule setup now that Stack.Workflow() is active - Fix Contentstack020_WorkflowTest: replace .Value<bool>() with .GetValue<bool>() for STJ JsonNode
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReleaseModel,PublishRuleModel, andDeleteReleaseItemServiceWorkflow,PublishRule,PublishQueue,Release, andReleaseItemto drop the legacy Newtonsoft serializer argumentStack.Release(),Stack.Workflow(), andStack.PublishQueue()methods (previously commented out pending migration)<Compile Remove>exclusions across core, unit test, and integration test projectsOpenJObjectResponse(Newtonsoft) toOpenJsonObjectResponse(STJ)BulkOperationTest.ClassInitializeand implemented the previously stubbedEnsureBulkTestWorkflowAndPublishingRuleAsyncTest Plan
dotnet build Contentstack.Management.Core/contentstack.management.core.csproj— 0 errorsdotnet test Contentstack.Management.Core.Unit.Tests/— all 991 tests passdotnet build Contentstack.Management.Core.Tests/— 0 errorsContentstack015_BulkOperationTest,Contentstack004_ReleaseTest,Contentstack020_WorkflowTestrun without workflow/Newtonsoft-related failures🤖 Generated with Claude Code