fix: Close Builder after signing#269
Open
tmathern wants to merge 3 commits into
Open
Conversation
ok-nick
reviewed
May 29, 2026
Comment on lines
+3532
to
+3537
| # Sign borrows the Builder without taking ownership. | ||
| # Closing here ensures resources clean up, | ||
| # and single use/single sign done by a Builder. | ||
| self.close() | ||
| except Exception as e: | ||
| self._mark_consumed() | ||
| self.close() |
Contributor
There was a problem hiding this comment.
Can we make sure this is documented in the function signatures just so it's not a surprise to anyone?
(not sure if that's done already or is any different from what we had previously)
ok-nick
approved these changes
May 29, 2026
Contributor
ok-nick
left a comment
ok-nick
left a comment
There was a problem hiding this comment.
Approving given the previous comment is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.