Skip to content

test/system: Try to prevent local 'skopeo copy' from timing out - #1826

Merged
debarshiray merged 1 commit into
containers:mainfrom
debarshiray:wip/rishi/test-system-libs-helpers-skopeo-copy-timeout-120s
Jul 28, 2026
Merged

test/system: Try to prevent local 'skopeo copy' from timing out#1826
debarshiray merged 1 commit into
containers:mainfrom
debarshiray:wip/rishi/test-system-libs-helpers-skopeo-copy-timeout-120s

Conversation

@debarshiray

Copy link
Copy Markdown
Member

The 60 second timeouts might not be quite enough for local skopeo copy because they sometimes fail with:

  not ok 187 run: Smoke test with 'exit 2'
  # tags: commands-options
  # (from function `assert_success' in file
       test/system/libs/bats-assert/src/assert.bash, line 114,
  #  from function `pull_distro_image' in file
       test/system/libs/helpers.bash, line 391,
  #  from function `pull_default_image' in file
       test/system/libs/helpers.bash, line 402,
  #  from function `create_default_container' in file
       test/system/libs/helpers.bash, line 470,
  #  in test file test/system/104-run.bats, line 806)
  #   `create_default_container' failed
  # ~ /home/zuul-worker/src/github.com/containers/toolbox
  # Failed to load image registry.fedoraproject.org/fedora-toolbox:45
      from cache
      /var/tmp/bats-run-yokdp3/suite/image-cache/fedora-toolbox-45
  #
  # -- command failed --
  # status : 1
  # output (3 lines):
  #   Getting image source signatures
  #   Copying blob sha256:8e0fe36f464ab46d2ce4ea3a1f2779c3921598ebf824e7
  #   time="2026-07-28T00:08:31Z" level=fatal msg="copying config:
        context deadline exceeded"
  # --
  #

So, double the timeouts to 120 seconds.

#1822

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

The 60 second timeouts might not be quite enough for local 'skopeo copy'
because they sometimes fail with:
  not ok 187 run: Smoke test with 'exit 2'
  # tags: commands-options
  # (from function `assert_success' in file
       test/system/libs/bats-assert/src/assert.bash, line 114,
  #  from function `pull_distro_image' in file
       test/system/libs/helpers.bash, line 391,
  #  from function `pull_default_image' in file
       test/system/libs/helpers.bash, line 402,
  #  from function `create_default_container' in file
       test/system/libs/helpers.bash, line 470,
  #  in test file test/system/104-run.bats, line 806)
  #   `create_default_container' failed
  # ~ /home/zuul-worker/src/github.com/containers/toolbox
  # Failed to load image registry.fedoraproject.org/fedora-toolbox:45
      from cache
      /var/tmp/bats-run-yokdp3/suite/image-cache/fedora-toolbox-45
  #
  # -- command failed --
  # status : 1
  # output (3 lines):
  #   Getting image source signatures
  #   Copying blob sha256:8e0fe36f464ab46d2ce4ea3a1f2779c3921598ebf824e7
  #   time="2026-07-28T00:08:31Z" level=fatal msg="copying config:
        context deadline exceeded"
  # --
  #

So, double the timeouts to 120 seconds.

containers#1822
containers#1826

Signed-off-by: Rolv Apneseth <rolv.apneseth@gmail.com>
@debarshiray
debarshiray force-pushed the wip/rishi/test-system-libs-helpers-skopeo-copy-timeout-120s branch from bce73d5 to 773768a Compare July 28, 2026 13:01
@debarshiray
debarshiray merged commit 773768a into containers:main Jul 28, 2026
3 checks passed
@debarshiray
debarshiray deleted the wip/rishi/test-system-libs-helpers-skopeo-copy-timeout-120s branch July 28, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants