Skip to content

Fix public download url #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 2 commits into from
Jun 22, 2026
+4 −4
Merged

Fix public download url #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49b4080
Fix poublic download url
NorOldBurden Jun 19, 2026
1844c1c
Update snapshot
NorOldBurden Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion graphile/graphile-presigned-url-plugin/src/download-url-field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export function createDownloadUrlPlugin(
}

if (isPublic && s3ForDb.publicUrlPrefix) {
return `${s3ForDb.publicUrlPrefix}/${key}`;
return `${s3ForDb.publicUrlPrefix}/${s3ForDb.bucket}/${key}`;
}

return generatePresignedGetUrl(
Expand Down
2 changes: 1 addition & 1 deletion graphql/env/__tests__/__snapshots__/merge.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ exports[`getEnvOptions merges pgpm defaults, graphql defaults, config, env, and
"bucketName": "test-bucket",
"endpoint": "http://localhost:9000",
"provider": "minio",
"publicUrlPrefix": "http://localhost:9000/test-bucket",
"publicUrlPrefix": "http://localhost:9000",
},
"db": {
"connections": {
Expand Down
2 changes: 1 addition & 1 deletion pgpm/env/__tests__/__snapshots__/merge.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ exports[`getEnvOptions merges defaults, config, env, and overrides 1`] = `
"bucketName": "test-bucket",
"endpoint": "http://localhost:9000",
"provider": "minio",
"publicUrlPrefix": "http://localhost:9000/test-bucket",
"publicUrlPrefix": "http://localhost:9000",
},
"db": {
"connections": {
Expand Down
2 changes: 1 addition & 1 deletion pgpm/types/src/pgpm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ export const pgpmDefaults: PgpmOptions = {
awsAccessKey: 'minioadmin',
awsSecretKey: 'minioadmin',
endpoint: 'http://localhost:9000',
publicUrlPrefix: 'http://localhost:9000/test-bucket'
publicUrlPrefix: 'http://localhost:9000'
},
deployment: {
useTx: true,
Expand Down
Loading