Update 04_ik_allow_collision.py - #481
Merged
Merged
Conversation
gonzalocasas
requested changes
Aug 13, 2026
gonzalocasas
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution! Super appreciated!!!
I like the switch to f-strings! I would ask you to use the "single-import per line" thou (I think the linter is configured to enforce that), and I would actually keep the output text, because it helps a first time user to understand what to expect
Contributor
Author
|
Thank you for the feedback! I've updated the script to follow the single-import per line rule and restored the expected output docstring block at the bottom as requested. |
gonzalocasas
approved these changes
Aug 13, 2026
Member
|
Awesome! Thanks!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes the IK collision example script by adopting Python f-strings, adding type annotations to the helper function, and incorporating clear docstrings to improve readability and code quality.
What type of change is this?
Checklist
CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_fab.robots.CollisionMesh.