feat: add a release-assets action - #1
Merged
Conversation
Packages that ship more than their distributions -- generated protobuf bindings, schema bundles -- were each writing the same four steps: check out, set up Python, run an Invoke task, upload what it produced. compas_pb and antikythera both had a copy. prepare-release can already carry extra assets through its release-assets input, but that ties generating them to `invoke pre-build`, which runs on every matrix job. Generating bindings for seven languages there would mean running protoc seven times per platform for a wheel build that does not need any of it. This action separates the two, uploading to the same artifact name so github-release attaches whatever it finds. The invoke-tasks input follows ci@v1 rather than introducing a generic shell-command action, which ARCHITECTURE.md rules out. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages that ship more than their distributions -- generated protobuf bindings, schema bundles -- were each writing the same four steps: check out, set up Python, run an Invoke task, upload what it produced.
prepare-release can already carry extra assets through its release-assets input, but that ties generating them to
invoke pre-build, which runs on every matrix job. Generating bindings for seven languages there would mean running protoc seven times per platform for a wheel build that does not need any of it. This action separates the two, uploading to the same artifact name so github-release attaches whatever it finds.The invoke-tasks input follows ci@v1 rather than introducing a generic shell-command action, which ARCHITECTURE.md rules out.